Warn no ip (#922)
* fix(scan): ignore wp-cli stderr messages (#825) (#915) * fix(scan): warn if unable to get ip address on the scan tareget server * fix test case
This commit is contained in:
		@@ -75,7 +75,8 @@ func (o *alpine) apkUpdate() error {
 | 
			
		||||
func (o *alpine) preCure() error {
 | 
			
		||||
	o.log.Infof("Scanning in %s", o.getServerInfo().Mode)
 | 
			
		||||
	if err := o.detectIPAddr(); err != nil {
 | 
			
		||||
		o.log.Debugf("Failed to detect IP addresses: %s", err)
 | 
			
		||||
		o.log.Warnf("Failed to detect IP addresses: %s", err)
 | 
			
		||||
		o.warns = append(o.warns, err)
 | 
			
		||||
	}
 | 
			
		||||
	// Ignore this error as it just failed to detect the IP addresses
 | 
			
		||||
	return nil
 | 
			
		||||
 
 | 
			
		||||
@@ -241,7 +241,8 @@ func (o *debian) checkDeps() error {
 | 
			
		||||
func (o *debian) preCure() error {
 | 
			
		||||
	o.log.Infof("Scanning in %s", o.getServerInfo().Mode)
 | 
			
		||||
	if err := o.detectIPAddr(); err != nil {
 | 
			
		||||
		o.log.Debugf("Failed to detect IP addresses: %s", err)
 | 
			
		||||
		o.log.Warnf("Failed to detect IP addresses: %s", err)
 | 
			
		||||
		o.warns = append(o.warns, err)
 | 
			
		||||
	}
 | 
			
		||||
	// Ignore this error as it just failed to detect the IP addresses
 | 
			
		||||
	return nil
 | 
			
		||||
 
 | 
			
		||||
@@ -1,6 +1,7 @@
 | 
			
		||||
package scan
 | 
			
		||||
 | 
			
		||||
import (
 | 
			
		||||
	"sort"
 | 
			
		||||
	"os"
 | 
			
		||||
	"reflect"
 | 
			
		||||
	"testing"
 | 
			
		||||
@@ -729,8 +730,8 @@ dpkg-query: no path found matching pattern /lib/udev/hwdb.bin
 | 
			
		||||
libuuid1:amd64: /lib/x86_64-linux-gnu/libuuid.so.1.3.0`,
 | 
			
		||||
			},
 | 
			
		||||
			wantPkgNames: []string{
 | 
			
		||||
				"udev",
 | 
			
		||||
				"libuuid1",
 | 
			
		||||
				"udev",
 | 
			
		||||
			},
 | 
			
		||||
		},
 | 
			
		||||
	}
 | 
			
		||||
@@ -738,6 +739,7 @@ libuuid1:amd64: /lib/x86_64-linux-gnu/libuuid.so.1.3.0`,
 | 
			
		||||
		t.Run(tt.name, func(t *testing.T) {
 | 
			
		||||
			o := &debian{}
 | 
			
		||||
			gotPkgNames := o.parseGetPkgName(tt.args.stdout)
 | 
			
		||||
			sort.Strings(gotPkgNames)
 | 
			
		||||
			if !reflect.DeepEqual(gotPkgNames, tt.wantPkgNames) {
 | 
			
		||||
				t.Errorf("debian.parseGetPkgName() = %v, want %v", gotPkgNames, tt.wantPkgNames)
 | 
			
		||||
			}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user