Do not use sudo when echo

scan/redhat.go

@@ -97,13 +97,8 @@ func detectRedhat(c config.ServerInfo) (itsMe bool, red osTypeInterface) {
 }
 
 func (o *redhat) checkIfSudoNoPasswd() error {
-	majorVersion, err := o.Distro.MajorVersion()
-	if err != nil {
-		return fmt.Errorf("Not implemented yet: %s, err: %s", o.Distro, err)
-	}
-
 	cmd := "yum --version"
-	if o.Distro.Family == "centos" && majorVersion < 6 {
+	if o.Distro.Family == "centos" {
 		cmd = "echo N | " + cmd
 	}
 	r := o.exec(cmd, o.sudo())
@@ -537,7 +532,7 @@ func (o *redhat) getAllChangelog(packInfoList models.PackageInfoList) (stdout st
 		packageNames += fmt.Sprintf("%s ", packInfo.Name)
 	}
 
-	command := ""
+	command := "echo N | "
 	if 0 < len(config.Conf.HTTPProxy) {
 		command += util.ProxyEnv()
 	}
@@ -550,14 +545,6 @@ func (o *redhat) getAllChangelog(packInfoList models.PackageInfoList) (stdout st
 		yumopts += " --skip-broken"
 	}
 
-	// CentOS 5 does not have --assumeno option.
-	majorVersion, _ := o.Distro.MajorVersion()
-	if majorVersion < 6 {
-		command = "echo N | " + command
-	} else {
-		yumopts += " --assumeno"
-	}
-
 	// yum update --changelog doesn't have --color option.
 	command += fmt.Sprintf(" LANGUAGE=en_US.UTF-8 yum %s --changelog update ", yumopts) + packageNames
 

scan/sshutil.go

@@ -328,6 +328,9 @@ func decolateCmd(c conf.ServerInfo, cmd string, sudo bool) string {
 	if sudo && c.User != "root" && !c.IsContainer() {
 		cmd = fmt.Sprintf("sudo -S %s", cmd)
 		cmd = strings.Replace(cmd, "|", "| sudo ", -1)
+
+		// echo command does not need sudo (for CentOS)
+		cmd = strings.Replace(cmd, "sudo -S echo", "echo", -1)
 	}
 
 	if c.Distro.Family != "FreeBSD" {