From a03a803b896a34e2ef9a495dffc5ddadad65eb1a Mon Sep 17 00:00:00 2001 From: James Sulinski Date: Thu, 9 Feb 2017 00:26:49 -0800 Subject: [PATCH] Reduce privilege requirements for commands that don't need sudo --- scan/debian.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scan/debian.go b/scan/debian.go index 77b3d6c7..e99b6f16 100644 --- a/scan/debian.go +++ b/scan/debian.go @@ -114,7 +114,7 @@ func trim(str string) string { } func (o *debian) checkIfSudoNoPasswd() error { - r := o.exec("apt-get -v", sudo) + r := o.exec("apt-get -v", noSudo) if !r.isSuccess() { o.log.Errorf("sudo error on %s", r) return fmt.Errorf("Failed to sudo: %s", r) @@ -333,7 +333,7 @@ func (o *debian) fillCandidateVersion(before models.PackageInfoList) (filled []m names = append(names, p.Name) } cmd := fmt.Sprintf("LANGUAGE=en_US.UTF-8 apt-cache policy %s", strings.Join(names, " ")) - r := o.exec(cmd, sudo) + r := o.exec(cmd, noSudo) if !r.isSuccess() { return nil, fmt.Errorf("Failed to SSH: %s", r) } @@ -355,7 +355,7 @@ func (o *debian) fillCandidateVersion(before models.PackageInfoList) (filled []m func (o *debian) GetUpgradablePackNames() (packNames []string, err error) { cmd := util.PrependProxyEnv("LANGUAGE=en_US.UTF-8 apt-get upgrade --dry-run") - r := o.exec(cmd, sudo) + r := o.exec(cmd, noSudo) if r.isSuccess(0, 1) { return o.parseAptGetUpgrade(r.Stdout) }