From 57264e1765ccc43f4de488c57ad468dcd6b76041 Mon Sep 17 00:00:00 2001 From: Kota Kanbe Date: Tue, 17 Oct 2023 17:58:21 +0900 Subject: [PATCH] fix(scan): fix nil poiter in needs-restarting (#1767) --- scanner/redhatbase.go | 2 +- scanner/redhatbase_test.go | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/scanner/redhatbase.go b/scanner/redhatbase.go index 468bce2a..47afa676 100644 --- a/scanner/redhatbase.go +++ b/scanner/redhatbase.go @@ -815,7 +815,7 @@ func (o *redhatBase) parseNeedsRestarting(stdout string) (procs []models.NeedRes } path := ss[1] - if !strings.HasPrefix(path, "/") { + if path != "" && !strings.HasPrefix(path, "/") { path = strings.Fields(path)[0] // [ec2-user@ip-172-31-11-139 ~]$ sudo needs-restarting // 2024 : auditd diff --git a/scanner/redhatbase_test.go b/scanner/redhatbase_test.go index 14216c15..144f2298 100644 --- a/scanner/redhatbase_test.go +++ b/scanner/redhatbase_test.go @@ -500,8 +500,14 @@ func TestParseNeedsRestarting(t *testing.T) { }{ { `1 : /usr/lib/systemd/systemd --switched-root --system --deserialize 21kk +30170 : 437 : /usr/sbin/NetworkManager --no-daemon`, []models.NeedRestartProcess{ + { + PID: "30170", + Path: "", + HasInit: true, + }, { PID: "437", Path: "/usr/sbin/NetworkManager --no-daemon",